Fix various parallelism issues #75
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiBardon
force-pushed
the
fix-parallelism
branch
3 times, most recently
from
eb28c2d
to
35f46ef
Compare
RemiBardon
force-pushed
the
fix-parallelism
branch
from
35f46ef
to
86e3c7f
Compare
…running locally
RemiBardon
force-pushed
the
fix-parallelism
branch
from
86e3c7f
to
e6f2349
Compare
In order to reuse the logic in other routes.
This allows un-hardcoding the timeout set when running parallel tasks.
RemiBardon
force-pushed
the
fix-parallelism
branch
from
e6f2349
to
7f8191d
Compare
…reused in other routes It does not depend on any HTTP REST concept or type so it has its place in `service::util`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #72.
This PR also ensures all tasks are canceled when the HTTP request is canceled, and adds a timeout for all individual tasks to make sure it doesn't exceed a customizable limit.