Add support for currency with pronamic_pay_currency field name or option.
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remcotolsma
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Perhaps combine $total = new Money(); on line 71 and $total = new Money( 0, \strtoupper( $currency ) ); on line 77, so it is also easier to track what the default currency is?
At first glance I found it a bit difficult to follow, because a new $total is created.
Currently, only payments in
EURare supported — the default currency of the https://github.com/pronamic/wp-money library.
And maybe document something in https://github.com/pronamic/wp-pronamic-pay-contact-form-7/blob/main/README.md? How does the tag or option work? Add examples? It should be an ISO 4217 currency code?
remcotolsma
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20.