Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #16 #17

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Fix for issue #16 #17

merged 7 commits into from
Dec 18, 2023

Conversation

remcotolsma
Copy link
Member

No description provided.

@remcotolsma remcotolsma self-assigned this Dec 14, 2023
@remcotolsma remcotolsma linked an issue Dec 14, 2023 that may be closed by this pull request
No sum of multiple amount fields/tags with the pronamic_pay_amount option #16
Closed
@rvdsteege
Copy link
Member

rvdsteege commented Dec 14, 2023 •
edited
Loading

Nice work, @remcotolsma! I have approved the PR, but the only thing I found is that we also supported the [text* pronamic_pay_amount] before (as tag name). Seems that is not documented on https://www.pronamicpay.com/en/manuals/how-to-connect-pronamic-pay-to-contact-form-7/, but it is possible that some users are using this syntax.

I'm fine with removing the support, but are we also fine with this backwards compatibility issue?

@remcotolsma
Copy link
Member Author

Nice work, @remcotolsma! I have approved the PR, but the only thing I found is that we also supported the [text* pronamic_pay_amount] before (as tag name). Seems that is not documented on https://www.pronamicpay.com/en/manuals/how-to-connect-pronamic-pay-to-contact-form-7/, but it is possible that some users are using this syntax.

I'm fine with removing the support, but are we also fine with this backwards compatibility issue?

Discussed @pronamic HQ, due to the less obvious Contact Form 7 tags, we want to maintain support for tag name.

@remcotolsma
Rename.
2159401
@remcotolsma
Merge branch '16-no-sum-of-multiple-amount-fieldstags-with-the-pronam…
76e371f 
…ic_pay_amount-option' of https://github.com/pronamic/wp-pronamic-pay-contact-form-7 into 16-no-sum-of-multiple-amount-fieldstags-with-the-pronamic_pay_amount-option
@remcotolsma remcotolsma merged commit 8f26fbd into main Dec 18, 2023
7 of 8 checks passed
@remcotolsma remcotolsma deleted the 16-no-sum-of-multiple-amount-fieldstags-with-the-pronamic_pay_amount-option branch December 18, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvdsteege rvdsteege Awaiting requested review from rvdsteege

Assignees

@remcotolsma remcotolsma

Labels
None yet
Projects
Pronamic Pay
Status: Done
Pronamic Pay 9.7
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No sum of multiple amount fields/tags with the pronamic_pay_amount option
2 participants
@remcotolsma @rvdsteege