Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add KubeJobNotCompleted runbook #49

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexandre1984rj
Copy link

Need to update the runbook since the alert was renamed into the kubernetes-mixin from KubeJobCompletion to KubeJobNotCompleted
kubernetes-monitoring/kubernetes-mixin#746

Signed-off-by: Alexandre de Sá <[email protected]>
Signed-off-by: Alexandre de Sá <[email protected]>
@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for distracted-northcutt-e0bccc ready!

Name Link
🔨 Latest commit d0bc397
🔍 Latest deploy log https://app.netlify.com/sites/distracted-northcutt-e0bccc/deploys/641c8609e204ef00079fdf3b
😎 Deploy Preview https://deploy-preview-49--distracted-northcutt-e0bccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandre1984rj
Copy link
Author

Hi there. Is there anything else to do before merging this PR?
Testing locally is OK https://imgur.com/a/TIpiRLy

@JoaoBraveCoding
Copy link

Hi @alexandre1984rj I'm not a maintainer of this repo so I can't comment on what might be missing, I'm just trying to help out with reviews. I see the CI has some problems but they might not be related to your PR

@alexandre1984rj
Copy link
Author

Really appreciate for your help @JoaoBraveCoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants