Fix memory leak and fix crash #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the CardTextField as a result of bugs in overriding first responder functions.
gringoireDM
approved these changes
Apr 4, 2019
iBozkurtHBC
approved these changes
Apr 4, 2019
…e a child text field resigns and the CardTextField itself becomes first responder. Note that the logic in becomeFirstResponder is the only way to ensure that the memory leak does not reappear.
iBozkurtHBC
approved these changes
Apr 5, 2019
AmauryVela
approved these changes
May 17, 2019
There was a problem hiding this comment.
This changes worked perfectly, it solved the crash we where having, please merge it. Nice job @classic-chris thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the overrides to becomeFirstResponder, resignFirstResponder, and isFirstResponder as they are causing UIKit to behave erroneously by creating a strong reference to the CardTextField that is not being released. Please see Issue #151 for details and reproducible steps.
My theory is that UIKit is having trouble that both the CardTextField and the child text field (NumberInputTextField for example) were both claiming to be the first responder at the same time.
Note that this could potentially be a breaking change if someone was relying on the logic in these overriden functions.