fix(template): don't use str[1] to get 1st char
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmillr
force-pushed
the
fix-template-stridx
branch
2 times, most recently
from
fc833cb to
e2cc3fe
Compare
In Lua, `str[1]` on a string always returns `nil`. Use `str:find('^#')`
instead of `str[1] == '#'` to check the first byte/char.
tmillr
force-pushed
the
fix-template-stridx
branch
from
e2cc3fe to
8405245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Lua,
str[1]on a string always returnsnil. Usestr:find('^#')instead ofstr[1] == '#'to check the first byte/char.