Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different versions per instance of a component #559

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Support different versions per instance of a component #559

wants to merge 5 commits into from

Commits on Jul 19, 2022

  1. Remove no-longer needed pylint ignores for type annotations 

    Recent pylint (or Python+pylint) versions can deal with `Optional[str]`
and similar type annotations without requiring the pylint annotation
`# pylint: disable=unsubscriptable-object`.
    @simu
    simu committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    3bc7026 View commit details
    Browse the repository at this point in the history

  2. WIP - Support different versions per alias of a component 

    Implemented:
* Create separate worktrees for each component alias
* Create class symlinks for each component alias
* Create each alias target with only the defaults and component class
  for the alias worktree
* Works only for components which use `${_base_directory}` in their
  config (kapitan.compile and kapitan.dependencies mainly)

TODO:
* Actually allow users to specify version for each alias separately
* Cleanup changes
* Add tests
* Update docs
    @simu
    simu committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    a154173 View commit details
    Browse the repository at this point in the history

  3. Update tests for new alias checkout structure

    @simu
    simu committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    8942dfd View commit details
    Browse the repository at this point in the history

  4. WIP - Allow users to specify instance versions 

    We add support for specifying instance versions in
`parameters.components`. Commodore falls back to the version/url/path
specified for the component when the keys are not provided for component
aliases.

Note that the actual dependency handling doesn't yet support overriding
URL/path for aliases.
    @simu
    simu committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    74bc54d View commit details
    Browse the repository at this point in the history

  5. Update tests to work with new alias version structure

    @simu
    simu committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    591f081 View commit details
    Browse the repository at this point in the history