event.keyCode deprecated #854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,23 +4,16 @@ import createEngine, { DiagramModel, DefaultNodeModel, DefaultLinkModel } from ' | |||
| import { CanvasWidget, Action, ActionEvent, InputType } from '@projectstorm/react-canvas-core'; | |||
| import { DemoCanvasWidget } from '../helpers/DemoCanvasWidget'; | |||
|
|
|||
| interface CustomDeleteItemsActionOptions { | |||
| keyCodes?: number[]; | |||
There was a problem hiding this comment.
I think we should still allow the user to specify the name of the keys. For example, it would be nice if they could specify Del, Backspace etc..
There was a problem hiding this comment.
Looks like you are right =)
But this feature will be disabled soon (not so soon, but still..)
I just though that codebase should be consistent with latest tendentions of the goodness of the code accepted in the community =)
Thanks for feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn run prettyWhat?
Why?
How?
Feel good image:
(Add your own one below :])