BugFix constructor overload in DefaultPortModel #1013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
pnpm changeset
and followed the instructionsWhat, why and how?
What: I changed the behaviour of setting "default" options when using the overloaded constructor of the DefaultPortModel.
Why: When creating a DefaultPortModel like:
new DefaultPortModel(true)
the in option wasn't set and label was undefinedHow: Wanted to change it, first made name mandatory (would be another option) but then adopted style like in DefaultNodeModel to typechecking options.
Feel good image:
PS: It's my first contribution sorry for any mistakes on the process.
PSS: wanted to Test but got: "The command '..' is incorrect or cannot be located in: reat-diagrams-routing test ../../node_modules/.bin/jest but the file is there. Maybe you can help thanks.
#997 (not exactly but points at the problem)