Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added homophily ratio in basic schelling example #2520

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

vbv-shm
Copy link

@vbv-shm vbv-shm commented Nov 26, 2024

Changed homophily comparing logic as per discussion in #2515.
Now homophily_ratio is checked for agents to be happy. homophily_ratio is similar neighboring agents divided by the total number of neighbors.

@vbv-shm vbv-shm changed the title Fix #2515 as per discussions in issues. Added homophily ratio in in basic schelling example #2515 Nov 27, 2024
@vbv-shm vbv-shm changed the title Added homophily ratio in in basic schelling example #2515 Added homophily ratio in basic schelling example Nov 27, 2024
@EwoutH EwoutH added the example Changes the examples or adds to them. label Nov 27, 2024
@EwoutH
Copy link
Member

EwoutH commented Nov 27, 2024

Thanks for the PR! Could you update your PR description to contain all the necessary information to understand this change on its own? You can use this template if you want.

Edit: I saw there's also this PR open, which also modifies schelling:

Are there any conflicts between them? I would tend to let #2518 go first, since it was opened earlier. (or did we assign someone to this specific issue?)

@vbv-shm vbv-shm closed this Nov 27, 2024
@vbv-shm vbv-shm reopened this Nov 27, 2024
@vbv-shm
Copy link
Author

vbv-shm commented Nov 27, 2024

@EwoutH Thank you for the reply.
I have understood that #2815 will be given priority because it was opened first. Still, can I work on this PR just in case #2815 doesn't work out? Or is this PR required to be closed?
From now on, I will be careful not to open PR for some issue if PR is already opened.

@quaquel
Copy link
Member

quaquel commented Nov 27, 2024

I have provided feedback in #2518, if that is not addressed in the coming days and there is no further response, I am fine with merging this instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Changes the examples or adds to them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants