Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues can be defined in sidekiq.yml #6

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

slemiere
Copy link

I am trying to use sidekiq-runner and my sidekiq.yml include the queue list. This change will fetch that information from the yml and apply it in the instance configuration.

@maltoe
Copy link
Contributor

maltoe commented May 2, 2016

Hey @slemiere,

the idea behind this separation of queue configuration and process configuration was to be able to keep the "business logic" side part of the code base (i.e. what queues are used, what's their weight, etc.), whereas settings used only to control a particular deployment (concurrency, logfiles/pidfiles, ...) a config option for sidekiq.yml. In particular, we wanted to ensure that some options from the code base are not allowed to be overwritten in the config file at all (hence the explicit CONFIG_FILE_ATTRIBUTES), including the queue configuration.

Having said that, there's of course no real argument against exposing everything in the single deployment case for example.

An idea: How about exposing everything / particular additional settings (:queues) conditionally, based on a in-codebase option? For example, there could be an .expose_internals! method on the configuration object passed to the .configure block. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants