This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Fixes recalculation of quality reports #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to recalculate patient caches we want to use the recalculate option in the calculation job. Using the recalculate flag we can force an expiration of results. We also added an expired_at value to the patient caches in order for them not to be included in future calculations and results. These can be purged at any time in the future.
This tests that recalculation only happens when we pass in the recalculation option. It also tests that on a second run the original results are expired and we only have the new results attached to the quality report.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recalculation option was being set on the quality report but not being persisted, so when
@quality_report.patients_cached?was being called the result was true.This PR also marks the associated patient results as expired so that they aren't used in the future and instead are recalculated.