Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.27] Auto pick #8085: Allow custom cgroup2 path #8512

Conversation

tomastigera
Copy link
Contributor

Cherry pick of #8085 on release-v3.27.

#8085: Allow custom cgroup2 path

Original PR Body below

Description

Currently, the mount-bpffs init container tries to create the folder /run/calico/cgroup for mounting the cgroupv2 fs

This causes issues on distros like Talos Linux as described in the issue #7892

This can be a configurable path instead

Related issues/PRs

#7892

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: alternative cgroup2 mount path can be specified by setting CALICO_CGROUP_PATH evn var for node.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@tomastigera tomastigera requested a review from a team as a code owner February 15, 2024 16:48
@tomastigera tomastigera added release-note-required Change has user-facing impact (no matter how small) cherry-pick-candidate docs-pr-required Change is not yet documented needs-operator-pr PRs that require follow-on operator work area/bpf eBPF Dataplane issues labels Feb 15, 2024
@marvin-tigera marvin-tigera added this to the Calico v3.27.1 milestone Feb 15, 2024
@tomastigera tomastigera added docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented needs-operator-pr PRs that require follow-on operator work cherry-pick-candidate labels Feb 15, 2024
Copy link
Member

@mazdakn mazdakn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomastigera
Copy link
Contributor Author

/merge-when-ready

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

@tomastigera tomastigera merged commit e06e0c9 into projectcalico:release-v3.27 Feb 15, 2024
1 of 2 checks passed
@tomastigera tomastigera deleted the auto-pick-of-#8085-release-v3.27 branch February 15, 2024 20:07
@tomastigera
Copy link
Contributor Author

unrelated failures in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bpf eBPF Dataplane issues docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants