Skip to content

Commit

Permalink
Fix sfdisk failure on older sfdisk
Browse files Browse the repository at this point in the history
We used to use following input file for sfdisk.

units:sectors
{dev}1: start=2048, size=4096, Id=8e

And this worked both with old and new sfdisk. But this required
hardcoding partition name and we wanted to move away from that
as it did not work for pmem and loop devices. So we started using
following format instead.

units:sectors
start=2048, size=4096, Id=8e

As per latest sfdisk man page this should work but it does not seem to
work with sfdisk shipped with older util-linux (util-linux-2.23.2-33),
and we get errors like following.

sfdisk: trailing junk after number

sfdisk: bad input

But following format seems to work with old sfdisk format. So switch
to using that one.

units:sectors
2048, 4096, 8e

Signed-off-by: Vivek Goyal <[email protected]>

Closes: #246
Approved by: rhvgoyal
  • Loading branch information
rhvgoyal authored and rh-atomic-bot committed Jun 30, 2017
1 parent 9b77bcb commit 927974f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions container-storage-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -821,8 +821,7 @@ create_partition_sfdisk(){
size=$(( $( awk "\$4 ~ /"$( basename $dev )"/ { print \$3 }" /proc/partitions ) * 2 - 2048 ))
cat <<EOF | sfdisk $dev
unit: sectors
start= 2048, size= ${size}, Id=8e
2048,${size},8e
EOF
}

Expand Down

0 comments on commit 927974f

Please sign in to comment.