sorry nikki im indecisive ok

src/dolphin/config/config.ts

@@ -7,7 +7,7 @@ import type { IniFile } from "./iniFile";
 export type SyncedDolphinSettings = {
   useMonthlySubfolders: boolean;
   replayPath: string;
-  jukebox: boolean;
+  enableJukebox: boolean;
 };
 
 export async function addGamePath(iniFile: IniFile, gameDir: string): Promise<void> {
@@ -20,16 +20,16 @@ export async function addGamePath(iniFile: IniFile, gameDir: string): Promise<vo
 
 export async function setSlippiSettings(iniFile: IniFile, options: Partial<SyncedDolphinSettings>): Promise<void> {
   const useMonthlySubfolders = options.useMonthlySubfolders ? "True" : "False";
-  const jukebox = options.jukebox ? "True" : "False";
+  const enableJukebox = options.enableJukebox ? "True" : "False";
   const coreSection = iniFile.getOrCreateSection("Core");
   if (options.replayPath !== undefined) {
     coreSection.set("SlippiReplayDir", options.replayPath);
   }
   if (options.useMonthlySubfolders !== undefined) {
     coreSection.set("SlippiReplayMonthFolders", useMonthlySubfolders);
   }
-  if (options.jukebox !== undefined) {
-    coreSection.set("SlippiJukeboxEnabled", jukebox);
+  if (options.enableJukebox !== undefined) {
+    coreSection.set("SlippiJukeboxEnabled", enableJukebox);
   }
   await iniFile.save();
 }
@@ -39,9 +39,9 @@ export async function getSlippiSettings(iniFile: IniFile): Promise<SyncedDolphin
   const useMonthlySubfolders = coreSection.get("SlippiReplayMonthFolders", "False") === "True";
   const replayPath = coreSection.get("SlippiReplayDir", defaultAppSettings.settings.rootSlpPath);
 
-  const jukebox = coreSection.get("SlippiJukeboxEnabled", "True") === "True";
+  const enableJukebox = coreSection.get("SlippiJukeboxEnabled", "True") === "True";
 
-  return { useMonthlySubfolders, replayPath, jukebox };
+  return { useMonthlySubfolders, replayPath, enableJukebox };
 }
 
 export async function setBootToCss(globalIni: IniFile, localIni: IniFile, enable: boolean): Promise<void> {

src/dolphin/manager.ts

@@ -219,7 +219,7 @@ export class DolphinManager {
 
     await this.settingsManager.setRootSlpPath(newSettings.replayPath);
     await this.settingsManager.setUseMonthlySubfolders(newSettings.useMonthlySubfolders);
-    await this.settingsManager.setJukebox(newSettings.jukebox);
+    await this.settingsManager.setEnableJukebox(newSettings.enableJukebox);
   }
 
   private _onStart(dolphinType: DolphinLaunchType) {

src/renderer/containers/Settings/MeleeOptions.tsx

@@ -15,7 +15,7 @@ import { Toggle } from "@/components/FormInputs/Toggle";
 import { PathInput } from "@/components/PathInput";
 import { useDolphinStore } from "@/lib/dolphin/useDolphinStore";
 import { useIsoVerification } from "@/lib/hooks/useIsoVerification";
-import { useIsoPath, useJukebox, useLaunchMeleeOnPlay } from "@/lib/hooks/useSettings";
+import { useEnableJukebox, useIsoPath, useLaunchMeleeOnPlay } from "@/lib/hooks/useSettings";
 
 import { SettingItem } from "./SettingItem";
 
@@ -39,7 +39,7 @@ export const MeleeOptions = React.memo(() => {
   const isoValidity = useIsoVerification((state) => state.validity);
   const [isoPath, setIsoPath] = useIsoPath();
   const [launchMeleeOnPlay, setLaunchMelee] = useLaunchMeleeOnPlay();
-  const [jukebox, setJukebox] = useJukebox();
+  const [enableJukebox, setEnableJukebox] = useEnableJukebox();
   const netplayDolphinOpen = useDolphinStore((store) => store.netplayOpened);
   const playbackDolphinOpen = useDolphinStore((store) => store.playbackOpened);
 
@@ -89,10 +89,10 @@ export const MeleeOptions = React.memo(() => {
       {showJukeboxToggle && (
         <SettingItem name="">
           <Toggle
-            value={jukebox}
-            onChange={(checked) => setJukebox(checked)}
+            value={enableJukebox}
+            onChange={(checked) => setEnableJukebox(checked)}
             label="Enable Music"
-            description="Enable music in game via Slippi Jukebox. Incompatible with WASAPI."
+            description="Enable in-game music via Slippi Jukebox. Incompatible with WASAPI."
             disabled={netplayDolphinOpen}
           />
         </SettingItem>

src/renderer/lib/hooks/useSettings.ts

@@ -42,12 +42,12 @@ export const useMonthlySubfolders = () => {
   return [useMonthlySubfolders, setUseMonthlySubfolders] as const;
 };
 
-export const useJukebox = () => {
-  const jukebox = useSettings((store) => store.settings.jukebox);
-  const setJukebox = async (toggle: boolean) => {
-    await window.electron.settings.setJukebox(toggle);
-  };
-  return [jukebox, setJukebox] as const;
+export const useEnableJukebox = () => {
+  const enableJukebox = useSettings((store) => store.settings.enableJukebox);
+  const setEnableJukebox = useCallback(async (toggle: boolean) => {
+    await window.electron.settings.setEnableJukebox(toggle);
+  }, []);
+  return [enableJukebox, setEnableJukebox] as const;
 };
 
 export const useSpectateSlpPath = () => {

src/settings/api.ts

@@ -7,9 +7,9 @@ import {
   ipc_editConnection,
   ipc_openSettingsModalEvent,
   ipc_setAutoUpdateLauncher,
+  ipc_setEnableJukebox,
   ipc_setExtraSlpPaths,
   ipc_setIsoPath,
-  ipc_setJukebox,
   ipc_setLaunchMeleeOnPlay,
   ipc_setNetplayDolphinPath,
   ipc_setPlaybackDolphinPath,
@@ -45,8 +45,8 @@ export default {
   async setUseMonthlySubfolders(toggle: boolean): Promise<void> {
     await ipc_setUseMonthlySubfolders.renderer!.trigger({ toggle });
   },
-  async setJukebox(toggle: boolean): Promise<void> {
-    await ipc_setJukebox.renderer!.trigger({ toggle });
+  async setEnableJukebox(toggle: boolean): Promise<void> {
+    await ipc_setEnableJukebox.renderer!.trigger({ toggle });
   },
   async setSpectateSlpPath(spectateSlpPath: string): Promise<void> {
     await ipc_setSpectateSlpPath.renderer!.trigger({ path: spectateSlpPath });

src/settings/defaultSettings.ts

@@ -23,7 +23,7 @@ export const defaultAppSettings: AppSettings = {
     isoPath: null,
     rootSlpPath: getDefaultRootSlpPath(),
     useMonthlySubfolders: false,
-    jukebox: true,
+    enableJukebox: true,
     spectateSlpPath: path.join(getDefaultRootSlpPath(), "Spectate"),
     extraSlpPaths: [],
     netplayDolphinPath: path.join(app.getPath("userData"), "netplay"),

src/settings/ipc.ts

@@ -15,7 +15,7 @@ export const ipc_setUseMonthlySubfolders = makeEndpoint.main(
   <SuccessPayload>_,
 );
 
-export const ipc_setJukebox = makeEndpoint.main("setJukebox", <{ toggle: boolean }>_, <SuccessPayload>_);
+export const ipc_setEnableJukebox = makeEndpoint.main("setEnableJukebox", <{ toggle: boolean }>_, <SuccessPayload>_);
 
 export const ipc_setSpectateSlpPath = makeEndpoint.main("setSpectateSlpPath", <{ path: string }>_, <SuccessPayload>_);
 

src/settings/settingsManager.ts

@@ -65,8 +65,8 @@ export class SettingsManager {
     await this._set("settings.useMonthlySubfolders", toggle);
   }
 
-  public async setJukebox(toggle: boolean): Promise<void> {
-    await this._set("settings.jukebox", toggle);
+  public async setEnableJukebox(toggle: boolean): Promise<void> {
+    await this._set("settings.enableJukebox", toggle);
   }
 
   public async setSpectateSlpPath(slpPath: string): Promise<void> {

src/settings/setup.ts

@@ -9,9 +9,9 @@ import {
   ipc_deleteConnection,
   ipc_editConnection,
   ipc_setAutoUpdateLauncher,
+  ipc_setEnableJukebox,
   ipc_setExtraSlpPaths,
   ipc_setIsoPath,
-  ipc_setJukebox,
   ipc_setLaunchMeleeOnPlay,
   ipc_setNetplayDolphinPath,
   ipc_setPlaybackDolphinPath,
@@ -63,10 +63,10 @@ export default function setupSettingsIpc({
     return { success: true };
   });
 
-  ipc_setJukebox.main!.handle(async ({ toggle }) => {
-    await settingsManager.setJukebox(toggle);
+  ipc_setEnableJukebox.main!.handle(async ({ toggle }) => {
+    await settingsManager.setEnableJukebox(toggle);
     const installation = dolphinManager.getInstallation(DolphinLaunchType.NETPLAY);
-    await installation.updateSettings({ jukebox: toggle });
+    await installation.updateSettings({ enableJukebox: toggle });
     return { success: true };
   });
 

src/settings/types.ts

@@ -21,7 +21,7 @@ export type AppSettings = {
     isoPath: string | null;
     rootSlpPath: string;
     useMonthlySubfolders: boolean;
-    jukebox: boolean;
+    enableJukebox: boolean;
     spectateSlpPath: string;
     extraSlpPaths: string[];
     netplayDolphinPath: string;