go back to using a for-loop for speed

src/database/repositories/player_repository.ts

@@ -10,17 +10,20 @@ export class PlayerRepository {
   }
 
   public static async findAllPlayersByGame(db: DB, ...gameId: number[]): Promise<Map<number, PlayerRecord[]>> {
-    const query = db.selectFrom("player").where("game_id", "in", gameId).orderBy(["player.game_id", "player.index"]);
+    const gameIdToPlayersMap = new Map<number, PlayerRecord[]>();
 
+    const query = db.selectFrom("player").where("game_id", "in", gameId).orderBy(["player.game_id", "player.index"]);
     const playerRecords = await query.selectAll().execute();
+    const totalRecords = playerRecords.length;
 
-    const gameIdToPlayersMap = new Map<number, PlayerRecord[]>();
-    playerRecords.forEach((player) => {
+    // We care about performance so use a for-loop for speed
+    for (let i = 0; i < totalRecords; i++) {
+      const player = playerRecords[i];
       const gameId = player.game_id;
       const players = gameIdToPlayersMap.get(gameId) ?? [];
       players.push(player);
       gameIdToPlayersMap.set(gameId, players);
-    });
+    }
 
     return gameIdToPlayersMap;
   }