fix: handle offline dolphin a bit better #2136
NikhilNarayanabuild.yml
on: push
Skip Duplicate Runs
4s
Matrix: build
Annotations
13 warnings
|
Test on node 18.x and ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/setup-node@v3, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test on node 18.x and ubuntu-latest:
src/broadcast/broadcast.worker.interface.ts#L36
Avoid using promises inside of callbacks
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/lib/dolphin/use_dolphin_listeners.ts#L54
React Hook useCallback has a missing dependency: 'showError'. Either include it or remove the dependency array
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/lib/hooks/use_mousetrap.ts#L32
React Hook useEffect has a missing dependency: 'evtType'. Either include it or remove the dependency array
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/lib/hooks/use_settings.ts#L92
React Hook useCallback has a missing dependency: 'dolphinType'. Either include it or remove the dependency array
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/pages/console_mirror/add_connection_dialog/add_connection_form.tsx#L136
`'` can be escaped with `'`, `‘`, `'`, `’`
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/pages/quick_start/steps/verify_email_step.tsx#L116
`'` can be escaped with `'`, `‘`, `'`, `’`
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/pages/replays/replay_browser/file_list.tsx#L66
React Hook React.useCallback has a missing dependency: 'onClick'. Either include it or remove the dependency array
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/pages/replays/replay_browser/file_list.tsx#L74
React Hook React.useEffect has a missing dependency: 'setScrollRowItem'. Either include it or remove the dependency array. If 'setScrollRowItem' changes too often, find the parent component that defines it and wrap that definition in useCallback
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/pages/replays/replay_browser/file_list.tsx#L81
React Hook React.useEffect has a missing dependency: 'listRef'. Either include it or remove the dependency array
|
|
Test on node 18.x and ubuntu-latest:
src/renderer/pages/replays/replay_file_stats/replay_file_stats.tsx#L122
`'` can be escaped with `'`, `‘`, `'`, `’`
|
|
Test on node 18.x and macOS-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/setup-node@v3, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test on node 18.x and windows-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/setup-node@v3, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
macOS-latest
Expired
|
203 MB |
|
|
ubuntu-latest
Expired
|
109 MB |
|
|
windows-latest
Expired
|
91.3 MB |
|