Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim SlippiDirectCodes to Rust port. #14

Open
wants to merge 2 commits into
base: slippi
Choose a base branch
from

Conversation

ryanmcgrath
Copy link
Collaborator

This changes out the internals of the SlippiDirectCodes class, wherein it'll now just silently call over to the Rust side. This keeps the changes minimal for now as we continue to migrate things out.

This notably lacks the change that Ishiiruka had to determine the user config folder path, since it appears the mainline build doesn't need it? Might need further testing there.

This compiles but has not been fully tested/vetted yet. Building this branch currently requires the corresponding branch from slippi-rust-extensions.

This changes out the internals of the `SlippiDirectCodes` class, wherein
it'll now just silently call over to the Rust side. This keeps the
changes minimal for now as we continue to migrate things out.

This notably lacks the change that Ishiiruka had to determine the user
config folder path, since it appears the mainline build doesn't need it?
Might need further testing there.

This compiles but has not been fully tested/vetted yet. Building this
branch currently requires the corresponding branch from
slippi-rust-extensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant