-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -p
/--slippi-port
cmd line option for spectate server port
#421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies for suddenly changing my mind, i re-read it and decided i'd rather have this be very explicit about what port it refers to
looks like there's a precedent for 'slippi spectate' as in
|
not necessarily against it, but i would like the corresponding config value to be renamed to match so it is easy to match them up, if you prefer just |
oh the config name lol oops. No I'll go spectator I don't want to change the config name that could be breaking if people are touching it programmatically |
fixes #419
this will allow developers to connect to the spectate server on multiple dolphin instances on the same machine