Full button remapping with native adapter

[jordan-zilch]

I've had people ask me for multiple button-swapping Slippi builds (X-Z swap, Y-Z swap, and X-Y swap) so I made a build which lets you remap all of the digital buttons.

FYI there isn't any kind of enforcement against illegal remapping here (in most Melee rulesets, you aren't allowed to have multiple buttons with the same button action mapped).

[BR-]

Would be nice if it'd zero out analog L/R if they're rebound to some other button:

diff --git a/Source/Core/InputCommon/GCAdapter.cpp b/Source/Core/InputCommon/GCAdapter.cpp
index 1e82201ed..125a91351 100644
--- a/Source/Core/InputCommon/GCAdapter.cpp
+++ b/Source/Core/InputCommon/GCAdapter.cpp
@@ -855,8 +855,22 @@ GCPadStatus Input(int chan, std::chrono::high_resolution_clock::time_point *tp)
                        pad.stickY = controller_payload_copy[1 + (9 * chan) + 4];
                        pad.substickX = controller_payload_copy[1 + (9 * chan) + 5];
                        pad.substickY = controller_payload_copy[1 + (9 * chan) + 6];
-                       pad.triggerLeft = controller_payload_copy[1 + (9 * chan) + 7];
-                       pad.triggerRight = controller_payload_copy[1 + (9 * chan) + 8];
+                       if (SConfig::GetInstance().m_LChoice[chan] == PAD_TRIGGER_L)
+                       {
+                               pad.triggerLeft = controller_payload_copy[1 + (9 * chan) + 7];
+                       }
+                       else
+                       {
+                               pad.triggerLeft = 0;
+                       }
+                       if (SConfig::GetInstance().m_RChoice[chan] == PAD_TRIGGER_R)
+                       {
+                               pad.triggerRight = controller_payload_copy[1 + (9 * chan) + 8];
+                       }
+                       else
+                       {
+                               pad.triggerRight = 0;
+                       }
                }
                else
                {

I'm not sure if 0 is the proper default value to use, but it does seem to work ingame. Swapping L and R will disable analog shields, not sure if that's ideal.

This is solvable without this by triggertricking, but it'd be nice to not require that. Maybe a triggertrick option could be cool too?

[jordan-zilch]

Swapping L and R will disable analog shields, not sure if that's ideal.

AFAIK switching L and R is completely pointless in Melee (it doesnt matter for shielding or quitting out of a match) so I don't think this will bother anyone.