Add support for Windows artifacts to Deliverables Analyzer #4137
Conversation
| purlBuilder = PackageURLBuilder.aPackageURL() | ||
| .withType(PackageURL.StandardTypes.GENERIC) | ||
| .withName(windowsArtifact.getName()) | ||
| .withVersion(windowsArtifact.getVersion()); |
There was a problem hiding this comment.
@pkocandr Should the namespace be empty? Type is GENERIC as there is no WINDOWS type.
| .collect(Collectors.joining(":")); | ||
| } else if (artifact instanceof WindowsArtifact) { | ||
| WindowsArtifact windowsArtifact = (WindowsArtifact) artifact; | ||
| return String.join("-", windowsArtifact.getName(), windowsArtifact.getVersion()); |
There was a problem hiding this comment.
@pkocandr For Windows, I just chose <name>-<version> as the identifier. I wonder if it's similar for NPM. It obviously will not match the Maven identifier format.
| deployPath = "/" + mavenArtifact.getGroupId().replace('.', '/') + "/" + mavenArtifact.getArtifactId() + "/" | ||
| + mavenArtifact.getVersion() + "/" + filename; | ||
| } else if (artifact instanceof WindowsArtifact) { | ||
| deployPath = "/" + filename; |
There was a problem hiding this comment.
@pkocandr I am not sure how the deploy path would be if we got that artifact via brew pull (is it even possible?) and if this matches.
There was a problem hiding this comment.
As I understand the code, this isn't the Maven repository path, e.g., /maven2. This is the original Brew path (see createBrewOriginURL()).
Maven artifacts start with /maven and Windows artifacts start with /win, so I think it just uses the artifact type to start the path. For Windows, since there is no group identifier, etc., the rest of the path is just the filename itself.
Checklist: