[NCL-8167] Implement Group Configs list edit page #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrikk0123
force-pushed
the
ncl8167-groupConfigsListEdit
branch
2 times, most recently
from
cfc08da to
9abfbe3
Compare
matedo1
requested changes
Oct 25, 2023
|
Hi @jomrazek , can you please do a code-review for this one? Very similar feature was already implemented here #312 (see Product Version > Build Configs (tab) > Edit list), this PR is re-using the same code, but Patrik generalised it for both entities - Group Config and Build Config Then he implemented some Group Config specific part on top of it. In this case React UI is very different from the AngularJS UI, as React UI adds full pagination support on all places. |
|
Apart Martin's comment about using new extendRequestConfig, it looks ok to me. |
patrikk0123
force-pushed
the
ncl8167-groupConfigsListEdit
branch
from
1c13ca0 to
45f5ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.