Add support for Windows artifacts in Deliverables Analyzer #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalluck
force-pushed
the
windows-artifact
branch
from
cb45871 to
aa9dda6
Compare
dwalluck
commented
Dec 12, 2024
| @Jacksonized | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonInclude(JsonInclude.Include.NON_NULL) | ||
| public class WindowsArtifact extends Artifact { |
There was a problem hiding this comment.
Prefer Windows or Win? Type constant from Koji is win.
There was a problem hiding this comment.
Yes. I looked at the code again, and I see that for Maven artifacts it spells out "Maven" and is not using an abbreviation like "Mvn", so I think the full name better matches the existing code.
There was a problem hiding this comment.
@janinko Wait, should WIN in ArtifactType also be changed to WINDOWS?
There was a problem hiding this comment.
I made the change for consistency. It will be called WINDOWS in pnc-api and WIN in kojiji.
dwalluck
force-pushed
the
windows-artifact
branch
from
aa9dda6 to
7055d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.