Add callback/notification #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejonnet
reviewed
Dec 17, 2024
ruhan1
reviewed
Dec 18, 2024
| try { | ||
| Request notificationCallback = new Request( | ||
| Request.Method.PUT, | ||
| new URI(StringUtils.appendIfMissing(config.selfBaseUrl(), "/") + "internal/completed"), |
There was a problem hiding this comment.
It seems the "internal/completed" REST api calls the Driver's "completed()" method which calls the "internal/completed" endpoint again... would this be an infinite loop?
There was a problem hiding this comment.
Sorry I missed this. The build endpoint takes a callback (to call back to PNC). That callback is embedded into the pipeline which is then passed to the PipelineNotification so the driver completed method should be instead calling the very first callback, not the internal endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.