Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCLSUP1134: Add error checking for broken Gradle version. #468

Merged
merged 2 commits into from
Sep 26, 2024
Merged

NCLSUP1134: Add error checking for broken Gradle version. #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c3ce3
NCLSUP1134: Add error checking for broken Gradle version.
rnc Sep 26, 2024
7eb27b5
Update to Gradle 8.10.2 for GHAction
rnc Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
strategy:
fail-fast: false
matrix:
gradle: [4.10.3, "5.0", 5.1.1, 5.2.1, 5.3.1, 5.4.1, 5.5.1, 5.6.4, 6.0.1, 6.1.1, 6.2.2, 6.3, 6.4.1, 6.5.1, 6.6.1, 6.7.1, 6.8.3, 6.9.4, 7.0.2, 7.1.1, 7.2, 7.3.3, 7.4.2, 7.5.1, 7.6.3, 8.0.2, 8.1.1, 8.2.1, 8.3, 8.4, 8.5]
gradle: [4.10.3, "5.0", 5.1.1, 5.2.1, 5.3.1, 5.4.1, 5.5.1, 5.6.4, 6.0.1, 6.1.1, 6.2.2, 6.3, 6.4.1, 6.5.1, 6.6.1, 6.7.1, 6.8.3, 6.9.4, 7.0.2, 7.1.1, 7.2, 7.3.3, 7.4.2, 7.5.1, 7.6.3, 8.0.2, 8.1.1, 8.2.1, 8.3, 8.4, 8.5, "8.10.2"]
# https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif
if: github.repository == 'project-ncl/gradle-manipulator' && github.event_name == 'pull_request'
runs-on: ubuntu-latest
Expand Down
5 changes: 5 additions & 0 deletions analyzer/src/main/java/org/jboss/gm/analyzer/alignment/AlignmentTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,11 @@
final ManipulationModel correspondingModule = alignmentModel.findCorrespondingChild(project);
if (configuration.versionModificationEnabled()) {
String newVersion = alignmentResponse.getProjectOverrides().get(project);
if (newVersion == null) {
logger.error("Using project {} but did not retrieve {}", project, value);
throw new ManipulationUncheckedException(

Check warning on line 378 in analyzer/src/main/java/org/jboss/gm/analyzer/alignment/AlignmentTask.java

View check run for this annotation

Codecov / codecov/patch

analyzer/src/main/java/org/jboss/gm/analyzer/alignment/AlignmentTask.java#L377-L378 

Added lines #L377 - L378 were not covered by tests
"Looping on project versions but unable to compare project. Are project comparisons broken?");
}
logger.info("Updating sub-project {} (path: {}) from version {} to {}", correspondingModule,
correspondingModule.getProjectPathName(), project.getVersion().toString(), newVersion);
correspondingModule.setOriginalVersion(project.getVersion().toString());
Expand Down
Loading