Skip to content

Commit

Permalink
NCLSUP1134: Add error checking for broken Gradle version.
Browse files Browse the repository at this point in the history
  • Loading branch information
rnc committed Sep 26, 2024
1 parent 6a58f2b commit 41e5153
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
strategy:
fail-fast: false
matrix:
gradle: [4.10.3, "5.0", 5.1.1, 5.2.1, 5.3.1, 5.4.1, 5.5.1, 5.6.4, 6.0.1, 6.1.1, 6.2.2, 6.3, 6.4.1, 6.5.1, 6.6.1, 6.7.1, 6.8.3, 6.9.4, 7.0.2, 7.1.1, 7.2, 7.3.3, 7.4.2, 7.5.1, 7.6.3, 8.0.2, 8.1.1, 8.2.1, 8.3, 8.4, 8.5]
gradle: [4.10.3, "5.0", 5.1.1, 5.2.1, 5.3.1, 5.4.1, 5.5.1, 5.6.4, 6.0.1, 6.1.1, 6.2.2, 6.3, 6.4.1, 6.5.1, 6.6.1, 6.7.1, 6.8.3, 6.9.4, 7.0.2, 7.1.1, 7.2, 7.3.3, 7.4.2, 7.5.1, 7.6.3, 8.0.2, 8.1.1, 8.2.1, 8.3, 8.4, 8.5, 8.10]
# https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif
if: github.repository == 'project-ncl/gradle-manipulator' && github.event_name == 'pull_request'
runs-on: ubuntu-latest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,11 @@ private void align(Configuration configuration, ManipulationCache cache, Manipul
final ManipulationModel correspondingModule = alignmentModel.findCorrespondingChild(project);
if (configuration.versionModificationEnabled()) {
String newVersion = alignmentResponse.getProjectOverrides().get(project);
if (newVersion == null) {
logger.error("Using project {} but did not retrieve {}", project, value);
throw new ManipulationUncheckedException(
"Looping on project versions but unable to compare project. Are project comparisons broken?");
}
logger.info("Updating sub-project {} (path: {}) from version {} to {}", correspondingModule,
correspondingModule.getProjectPathName(), project.getVersion().toString(), newVersion);
correspondingModule.setOriginalVersion(project.getVersion().toString());
Expand Down

0 comments on commit 41e5153

Please sign in to comment.