Skip to content

Commit

Permalink
Use multi-arch container images for development (#5045)
Browse files Browse the repository at this point in the history
Instead of pulling different images from different registries and maintaining
a separate Docker Compose file, use images that contain both architectures.
  • Loading branch information
samdoran authored Apr 26, 2024
1 parent cbadee1 commit 506059a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 16 deletions.
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,7 @@ ifneq ($(DOCKER_COMPOSE_CHECK), 0)
DOCKER_COMPOSE_BIN = $(DOCKER)-compose
endif

# Use ARM images on ARM systems
DOCKER_COMPOSE = $(DOCKER_COMPOSE_BIN)
ifeq (arm, $(findstring arm, $(shell uname -m)))
DOCKER_COMPOSE = $(DOCKER_COMPOSE_BIN) -f docker-compose.yml -f docker-compose.arm.yml
endif

# Testing directories
TESTINGDIR = $(TOPDIR)/testing
Expand Down
10 changes: 0 additions & 10 deletions docker-compose.arm.yml

This file was deleted.

4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ services:
hive-metastore:
container_name: hive-metastore
image: quay.io/cloudservices/ubi-hive:3.1.3-metastore-024
image: quay.io/samdoran/ubi-hive:3.1.3-metastore-036
ports:
- 9083:8000
environment:
Expand All @@ -637,7 +637,7 @@ services:

trino:
container_name: trino
image: quay.io/cloudservices/ubi-trino:443-002
image: quay.io/samdoran/ubi-trino:443-002
user: root
ports:
- 8080:8080
Expand Down

0 comments on commit 506059a

Please sign in to comment.