Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New export for callPhoneModal + fix for issue #894 #898

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

New export for callPhoneModal + fix for issue #894 #898

wants to merge 1 commit into from

Conversation

NewEditOfficial
Copy link

@NewEditOfficial NewEditOfficial commented Oct 11, 2022 •
edited
Loading

Pull Request Description

This should allow use to handle phoneModal by our logic and it will resolve issue with hiding callModal (as for now)

  • Its way arround, even exports.npwd:setPhoneVisible(false) is failing to hide callPhoneModal.

Issue #894

Pull Request Checklist:

  • [Yes] Have you followed the guidelines in our Contributing document and Code of Conduct?
  • [Yes] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [Yes] Have you built and tested NPWD in-game after the relevant change?

@NewEditOfficial
feat (callModal): new export with option to handleCall modal
af05a9d 
feat (callModal): new export with option to handleCall modal
@NewEditOfficial NewEditOfficial mentioned this pull request Oct 11, 2022
Closed
@itschip itschip self-assigned this Oct 12, 2022
@itschip itschip added Awaiting Code Review Awaiting code review. Awaiting Testing Awaiting in-game testing. labels Oct 12, 2022
@NewEditOfficial
Copy link
Author

Any update? 👀

@itschip
Copy link
Member

itschip commented Oct 30, 2022

@NewEditOfficial You need to rebase this branch and resolve the conflicts.

@AvarianKnight AvarianKnight added the PR Conflicts Pull request has conflicts that need to be resolved. label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@itschip itschip

Labels
Awaiting Code Review Awaiting code review. Awaiting Testing Awaiting in-game testing. PR Conflicts Pull request has conflicts that need to be resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewEditOfficial @itschip @AvarianKnight