Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new_da.json #1125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iplayer1337fivem
Copy link
Contributor

this is a new danish, since there is a da.json but its not in the phone. Hope it will get back, so we can get some fun with this as well. TY in advance

Pull Request Description

Please include a general description of the changes made, why they were necessary,
and any other general things to note.

Pull Request Checklist:

  • [ x] Have you followed the guidelines in our Contributing document and Code of Conduct?
  • [ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [ no] Have you built and tested NPWD in-game after the relevant change? Because I cant get it there. Im sorry. but I checked with the en.json and a compare tool, and no errors

this is a new danish, since there is a da.json but its not in the phone. Hope it will get back, so we can get some fun with this as well. TY in advance
@itschip
Copy link
Member

itschip commented Jan 19, 2024

Please update da.json instead :)

@itschip
Copy link
Member

itschip commented Jan 19, 2024

You also need to add the language in the config

https://github.com/project-error/npwd/blob/master/apps/phone/src/config/default.json#L78

@iplayer1337fivem
Copy link
Contributor Author

fair enough, I had to do another way than usually, im sorry for wasting you time. :) I think I did it correct now. TY in advance

@jfrader
Copy link
Contributor

jfrader commented Jan 23, 2024

Not sure if you use this but its helpful to know what is missing, can probably try adding 'da' here
https://github.com/project-error/npwd/blob/master/apps/phone/i18n.missingKeys.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants