Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix osx issue with reading floats #741

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mkstoyanov
Copy link
Collaborator

This should fix the issue with float precision in Mac.

Basically, the >> fails to read the double data as floats.

@quantumsteve
Copy link
Collaborator

What do you think about creating a minimal reproducible example for libc++?

Copy link
Collaborator

@quantumsteve quantumsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this into develop and rebase #738.

@mkstoyanov
Copy link
Collaborator Author

@quantumsteve

I'm overriding the test requirement, we have too many tests now, we should disable the duplicates from AWS.

@mkstoyanov mkstoyanov merged commit 56171cc into project-asgard:develop Sep 19, 2024
15 checks passed
@mkstoyanov mkstoyanov deleted the osx_read_float_fix branch September 19, 2024 21:21
@mkstoyanov
Copy link
Collaborator Author

What do you think about creating a minimal reproducible example for libc++?

We can do that but I also want to check what the standard says too.

@quantumsteve
Copy link
Collaborator

@quantumsteve

I'm overriding the test requirement, we have too many tests now, we should disable the duplicates from A

I've disabled the duplicate tests from running on pull requests but haven't figured out why GitHub is still waiting for results from them.

@mkstoyanov
Copy link
Collaborator Author

@quantumsteve
I'm overriding the test requirement, we have too many tests now, we should disable the duplicates from A

I've disabled the duplicate tests from running on pull requests but haven't figured out why GitHub is still waiting for results from them.

So we're waiting on tests that will never run.

Must be something in the hooks, there must be something in the github setup that is calling AWS. Maybe something in the AWS has to be force-updated ... ugh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants