Refactoring Cargo.toml makes the current version code compatible with the old #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the old version code, and the provider defaults to using ring and supports tls1.2
c5soft
changed the title
c5soft
changed the title
|
The default being However, I do agree that TLS v1.2 should be enabled by default, which I've already done here: #130. On a side note: Ring also requires a C toolchain, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Cargo.toml makes the current version code compatible with the old version code. The provider defaults to ring (replacing aws-lc-rs which involves C/NASM compiling) and supports tls1.2 included. This is very important for production as supporting only tls1.3 without tls1.2 may cause old client systems to crash.