Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getting Started text editor recommendations #1493

Closed
wants to merge 3 commits into from
Closed

Update Getting Started text editor recommendations #1493

wants to merge 3 commits into from

Conversation

joenash
Copy link

@joenash joenash commented Jan 19, 2024

Fixes #1492

Changes:

  • Replaced Atom with Visual Studio Code
  • Updated Sublime Text 2 to just "Sublime Text", with a link to the generic download page

Todo:

Copy link
Member

@nickmcintyre nickmcintyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joenash please make a couple of adjustments:

  • Limit the list of editors to Visual Studio Code
  • Revise the Sublime guide to use VS Code instead (including screenshot)

@joenash
Copy link
Author

joenash commented Jan 19, 2024

Hey @nickmcintyre,

I've made those changes, I do have questions about the i18n handling though. I removed environment blocks 5-7 in index.hbs, but wasn't sure if I should remove the corresponding entries in en.yml, or update the numbering scheme, as I didn't want to cause issues for the other translations.

I guess given the upcoming docs revamp that having some redundant lines lurking in the en.yml isn't the end of the world, but wanted to flag it just in case!

Copy link
Member

@nickmcintyre nickmcintyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great @joenash!

Copy link
Member

@nickmcintyre nickmcintyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. @joenash upon further review, the translations don't read clearly at all with the environment blocks removed.

How about we try restoring the environment blocks and simply put blank strings in en.yml?

@joenash
Copy link
Author

joenash commented Feb 1, 2024

Sorry for the delay @nickmcintyre, this should be done now!

@limzykenneth
Copy link
Member

@joenash @nickmcintyre Is this ready for merge?

@nickmcintyre
Copy link
Member

@limzykenneth nope, translations are still broken (missing links in the middle of sentences). Restoring the other editors to templates/pages/get-started/index.hbs fixes the translations but breaks English (links to other editors appear out of context).

@joenash I suggest we close this issue in keeping with #1452. I'm sorry this fix wasn't as straightforward as I thought. The new p5.js website will be launched in a couple of months and there will countless opportunities to contribute!

@joenash
Copy link
Author

joenash commented Mar 3, 2024

Sounds good, thanks @nickmcintyre. No need to apologise, sorry for taking up your time with reviewing this, I wasn't very familiar with the translation system going in and I should have checked what was happening there before opening the PR. Looking forward to the new site!

@joenash joenash closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the list of editors in Getting Started (Atom has been sunset)
3 participants