-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: provide ways to limit the number of "e2e tests" runs #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e workflow currently runs 11 jobs. Since the GitHub organization allows a maximum of 20 concurrent jobs (with only 5 runners for macOS), it is essential to limit unnecessary runs. This is particularly important when drafting a PR, as running these tests can often be deferred and re-enabled later. For example, temporarily disabling e2e tests during the drafting phase and re-enabling them later without committing configuration changes (e.g., removing or editing the workflow file) helps to significantly reduce redundant runs. Implemented Improvements - Concurrency Control: Automatically stop workflows for older commits when multiple commits are pushed in quick succession, ensuring that only the latest commit triggers the workflow. - Skip on Demand: Enable skipping workflow runs by setting a specific label on the PR.
tbouffard
added
chore
Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
skip CI e2e tests
GitHub Actions do not run e2e tests (for Pull Requests)
labels
Oct 21, 2024
❌ The e2e tests workflow is currently invalid ✔️ workflow syntax OK thanks to b3ce5c3. ✔️ Concurrency group configuration |
tbouffard
removed
the
skip CI e2e tests
GitHub Actions do not run e2e tests (for Pull Requests)
label
Oct 21, 2024
This reverts commit 272e714.
csouchet
approved these changes
Oct 28, 2024
tbouffard
added
the
skip CI e2e tests
GitHub Actions do not run e2e tests (for Pull Requests)
label
Oct 28, 2024
tbouffard
changed the title
ci: provide ways to limit the number of "e2e tests" workflow runs
ci: provide ways to limit the number of "e2e tests" runs
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
skip CI e2e tests
GitHub Actions do not run e2e tests (for Pull Requests)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e workflow currently runs 11 jobs. Since the GitHub organization allows a maximum of 20 concurrent jobs (with only 5 runners for macOS), it is essential to limit unnecessary runs.
This is particularly important when drafting a PR, as running these tests can often be deferred and re-enabled later. For example, temporarily disabling e2e tests during the drafting phase and re-enabling them later without committing configuration changes (e.g., removing or editing the workflow file) helps to significantly reduce redundant runs.
Implemented Improvements
Notes
Closes #2172
Will be improved by #3196