Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: better configure the "paths" triggering the execution of workflows running tests #2722

Merged
merged 5 commits into from
Jun 1, 2023
Merged

ci: better configure the "paths" triggering the execution of workflows running tests #2722

merged 5 commits into from
Jun 1, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented May 31, 2023 •
edited by tbouffard
Loading

The workflows running the tests were not executed when the shared configuration was updated.
The build workflow was also triggered too often, for instance, when the e2e tests were modified.

Covers #2172

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label May 31, 2023
@csouchet csouchet marked this pull request as ready for review May 31, 2023 08:30
@csouchet csouchet requested a review from tbouffard May 31, 2023 08:31
tbouffard
tbouffard reviewed May 31, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "npm package" workflow is also missing some elements in the "paths" configuration:

  • 'test/*' # root folder
  • 'test/config/**/*'
  • 'test/shared/**/*'

I have also detected that the root 'tsconfig.test.json' file is missing is all workflows running tests.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@csouchet csouchet requested a review from tbouffard May 31, 2023 09:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

tbouffard
tbouffard approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for having detected the problem.

@tbouffard tbouffard changed the title ci: fix launch of e2e and performance tests workflows and run less often build workflow ci: better configure the "paths" triggering the execution of workflows running tests Jun 1, 2023
@tbouffard tbouffard merged commit 52cfdbc into master Jun 1, 2023
@tbouffard tbouffard deleted the fix_workflows_for_launch_tests branch June 1, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard