Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use the "Update Style" API in the "Elements Identification" demo #2630

Merged
merged 8 commits into from
Apr 24, 2023
Merged

feat: use the "Update Style" API in the "Elements Identification" demo #2630

merged 8 commits into from
Apr 24, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Apr 18, 2023 •
edited
Loading

  • Export missing type for the API documentation : StyleWithOpacity
    image
    image

  • Add a radio button to select the mode to apply the style: CSS or API
    image

  • Update the style according the selected BPMN kind and the style method (CSS or API).
    When switching from CSS to API, the CSS class applied to the selected BPMN kind are cleared.

  • Introduce new function in the main JS file for Elements Identification demo, to style without parameters: updateStyle

Closes #2558

@csouchet csouchet added the example This issue or pull request is related to the lib demo or examples label Apr 18, 2023
@csouchet csouchet mentioned this pull request Apr 18, 2023
Closed
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited
Loading

♻️ PR Preview c8f8f23 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet added the enhancement New feature or request label Apr 18, 2023
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited
Loading

♻️ PR Preview c8f8f23 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet marked this pull request as ready for review April 18, 2023 13:33
@csouchet csouchet requested a review from tbouffard April 18, 2023 13:33
@tbouffard tbouffard changed the title feat(demo): use the new Update Style API in the Elements Identification demo feat: use the "Update Style" API in the "Elements Identification" demo Apr 24, 2023
tbouffard
tbouffard approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job
✔️ Tested with the surge preview environment: https://process-analytics-bpmn-visualization-js-demo_preview-pr-2630.surge.sh/dev/public/elements-identification.html

dev/public/static/js/elements-identification.js Outdated Show resolved Hide resolved
dev/public/static/js/elements-identification.js Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet enabled auto-merge (squash) April 24, 2023 13:36
@csouchet csouchet merged commit 9b7320c into master Apr 24, 2023
@csouchet csouchet deleted the 2558-Add_radio_button_to_choose_the_style_feature branch April 24, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request example This issue or pull request is related to the lib demo or examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEMO] Use the new Update Style API in "elements-identification.html"
2 participants
@csouchet @tbouffard