Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Automate tag and files update #145

Merged
merged 8 commits into from
Nov 22, 2022
Merged

[INFRA] Automate tag and files update #145

merged 8 commits into from
Nov 22, 2022

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Nov 18, 2022 •
edited by tbouffard
Loading

Add new workflow for the release: release.yml including the following steps (in order):

  • unprotect the branch
  • generate the new version with https://github.com/marketplace/actions/create-new-semantic-version (based on the latest git tag)
  • update the README.md and DESCRIPTION files with the new version
  • commit the changes
  • tag, then push the commit and tag
  • update the DESCRIPTION file with the new development version
  • commit and push it
  • protect the branch again

Closes #47

Test

See this PR to see the tests with patch, minor and major version: process-analytics/github-actions-playground#173

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Nov 18, 2022
@tbouffard tbouffard mentioned this pull request Nov 18, 2022
Closed
tbouffard
tbouffard reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ if we automate the files update, we should update the release process documentation as well.
See also #146

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@csouchet csouchet force-pushed the 47-automate_tag_and_files_update_in_R_package branch 4 times, most recently from 11e70be to 4f20f25 Compare November 22, 2022 09:50
@csouchet
Merge remote-tracking branch 'origin/main' into fix_maintainer_doc
5bd408a
@csouchet
Add new workflow for the relesae: release.yml
f3305cc 
  - with a step to unprotect the branch
  - with a step to generate new version with https://github.com/marketplace/actions/create-new-semantic-version
  - with a step to get the current version, update README.md and DESCRIPTION files with the release version
  - with a step to commit them
  - with a step to tag and push it
  - with a step to update DESCRIPTION file with the development version
  - with a step to commit it
  - with a step to protect the branch
@csouchet csouchet force-pushed the 47-automate_tag_and_files_update_in_R_package branch from 4f20f25 to f3305cc Compare November 22, 2022 09:56
@csouchet csouchet marked this pull request as ready for review November 22, 2022 10:08
@csouchet csouchet requested a review from tbouffard November 22, 2022 10:08
@csouchet csouchet added depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first and removed WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Nov 22, 2022
@tbouffard tbouffard removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Nov 22, 2022
tbouffard
tbouffard approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited
Loading

🎊 PR Preview 07c7333 has been successfully built and deployed to https://process-analytics-bpmn-visualization-R-pr_preview-pr-145.surge.sh

🕐 Build time: 0.014s

🤖 By surge-preview

csouchet
csouchet commented Nov 22, 2022
View reviewed changes
MAINTAINERS.md Outdated Show resolved Hide resolved
@tbouffard @csouchet
fix manual procedure
07c7333 
Co-authored-by: Souchet Céline <[email protected]>
@tbouffard tbouffard merged commit 47878c8 into main Nov 22, 2022
@tbouffard tbouffard deleted the 47-automate_tag_and_files_update_in_R_package branch November 22, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INFRA] Automate tag and files update
2 participants
@csouchet @tbouffard