Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better identify incoming and outgoing edges #128

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 22, 2024

Previously, it was possible to have vertically incoming and vertically outgoing edges on the same shape.
This made it difficult to distinguish one from the other.
This usually happened on gateways.

To easily identify the two edge types, only incoming edges can now be connected vertically.
Outgoing edges always start with a small horizontal segment.

Screenshots

BPMN

PR_128_gateways

SVG

waypoints-positions-gateways bpmn xml

@tbouffard tbouffard changed the title feat/improve_edge_output_direction feat: improve edge output waypoint (always first horizontal segment) Aug 22, 2024
@tbouffard tbouffard added the enhancement New feature or request label Aug 22, 2024
Previously, it was possible to have vertically incoming and vertically outgoing edges on the same shape.
This made it difficult to distinguish one from the other.
This usually happened on gateways.

To easily identify the two edge types, only incoming edges can now be connected vertically.
Outgoing edges always start with a small horizontal segment.
@tbouffard tbouffard force-pushed the feat/improve_edge_output_direction branch from be88497 to 7663e54 Compare August 23, 2024 05:20
@tbouffard tbouffard changed the title feat: improve edge output waypoint (always first horizontal segment) feat: better identify incoming and outgoing edges Aug 23, 2024
@tbouffard tbouffard marked this pull request as ready for review August 23, 2024 05:27
@tbouffard tbouffard merged commit be34c5a into master Aug 23, 2024
6 checks passed
@tbouffard tbouffard deleted the feat/improve_edge_output_direction branch August 23, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant