-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use skore-ui widgets in notebooks #926
Conversation
Coverage Report for ./skore-ui
File Coverage
|
Ping @koaning |
If we just support Jupyter for now that sure seems fine. While I am a fan of Marimo I would argue that this is always possible as an add-on feature later. Looking at the video though ... it seems that the altair chart does not show the axes? @rouk1 might that be a bug? |
Nice catch I need to look at this. |
This PR introduces a theme toggle that overwrites user preferences. Depends on #926 that introduces class based theme management.
fa87c5b
to
aeaab36
Compare
This PR introduces a theme toggle that overwrites user preferences. Depends on #926 that introduces class based theme management. # UI preview https://github.com/user-attachments/assets/5a220d2b-d201-4787-98a2-db0b5c9917f7
This PR makes our existing widgets available in notebooks.
UI preview
vscode notebooks
widgets.mp4
JupyterLab
jupyter-widgets.mp4
Warning
For now Marimo is not supported as it requires to use Anywidget, I'd like to split this rework in another PR to merge this then iterate.
My Hex demo is expired so I could not test it : (
Implementation choices/details front
.skore-ui
) to avoid style leakmain.ts
now instantiate it's main app dynamically according to it's container namerouter.ts
does not instantiate the browser history as a side effect (this feature is blocked by vs code)Implementation choices/details back
get_serializable_dict
method that returns a JSON serializable dict_repr_mimebundle_
method that returns supported media types (for now HTML only)get_serializable_dict
method