Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the CrossValidationReporter plot to have scores in one side, and time on the other side #902

Open
MarieS-WiMLDS opened this issue Dec 10, 2024 · 0 comments · May be fixed by #986
Open
Assignees
Labels
enhancement New feature or request

Comments

@MarieS-WiMLDS
Copy link
Contributor

MarieS-WiMLDS commented Dec 10, 2024

Is your feature request related to a problem? Please describe.

In the version to come (v0.5.0), the CrossValidationReporter has only one plot, with scores and time at the same place. It doesn't make much sense because 99.99% of the time, they will not have the same magnitude, therefore it's troublesome to see them at the same place.

Describe the solution you'd like

I'd like to have three different plots. Keeping the current one: CrossValidationReporter.plots.compare_scores, but without the timings. And add a two new ones: CrossValidationReporter.plots.timing with the fit_time & score_time, and CrossValidationReporter.plots.timing_normalized with the fit_time_per_data_point & score_time_per_data_point

Describe alternatives you've considered, if relevant

remove the time, but it's interesting so it would be a bummer to remove them.

Additional context

No response

@MarieS-WiMLDS MarieS-WiMLDS added the enhancement New feature or request label Dec 10, 2024
@augustebaum augustebaum self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants