Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directory is contributed_definitions #203

Merged

Conversation

woutdenolf
Copy link
Contributor

It was not finding a contribution. I fixed it in one place but it could be in others. In general there is a mixup between the directory of the nxdl file and the category, which is not the same.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.221% when pulling 5883b18 on woutdenolf:contributed_definitions_category into 32d9c3b on prjemian:main.

@prjemian
Copy link
Owner

prjemian commented Jul 1, 2022

Overall needs a better way to identify when a term has multiple meanings. See #166.

@prjemian prjemian added this to the v1.0.0-release milestone Jul 1, 2022
@prjemian prjemian added the bug label Jul 1, 2022
Copy link
Owner

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Seems that unit testing has missed this. I'll handle that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants