Merge pull request #159 from prjemian/lgtm-hints

Fix some hints from LGTM

punx/github_handler.py

@@ -197,7 +197,6 @@ def _get_last_modified(self):
         """get the ``last_modified`` date from the SHA's commit"""
         if self.sha is not None:
             commit = self.repo.get_commit(self.sha)
-            mod_date_time = commit.last_modified  # Tue, 20 Dec 2016 18:30:29 GMT
             fmt = "%a, %d %b %Y %H:%M:%S %Z"  # --> 2016-11-19 01:04:28
             mod_date_time = datetime.datetime.strptime(commit.last_modified, fmt)
             self.last_modified = str(mod_date_time)

punx/validate.py

@@ -298,10 +298,10 @@ def get_subject(parent, o):
             else:
                 get_subject(parent, group[item])
 
-    def validate_item_name(self, v_item, key=None):
+    def validate_item_name(self, v_item):
         from .validations import item_name
 
-        item_name.verify(self, v_item, key)
+        item_name.verify(self, v_item)
 
     def validate_attribute(self, v_item):
         from .validations import attribute

punx/validations/item_name.py

@@ -40,14 +40,13 @@ def isNeXusLinkTarget(v_item):
     return False  # no @target attribute at all
 
 
-def verify(validator, v_item, key=None):
+def verify(validator, v_item):
     """
     check :class:`ValidationItem` *v_item* using *validItemName* regular expression
 
     This is used for the names of groups, fields, links, and attributes.
 
     :param obj v_item: instance of :class:`ValidationItem`
-    :param str key: named key to search, default: None (``validItemName``)
 
     This method will test the object's name for validation,
     comparing with the strict or relaxed regular expressions for
@@ -72,8 +71,6 @@ def verify(validator, v_item, key=None):
     if "name" in v_item.validations:
         return  # do not repeat this
 
-    key = key or "validItemName"
-
     if v_item.h5_address is not None and v_item.h5_address.endswith("@NX_class"):
         handle_NX_class(validator, v_item)
 

setup.py

@@ -11,7 +11,7 @@
 # The full license is in the file LICENSE, distributed with this software.
 # -----------------------------------------------------------------------------
 
-from setuptools import setup, find_packages
+from setuptools import setup
 import os
 import versioneer