Skip to content

Commit

Permalink
gcc: do not warn about unreachable switches
Browse files Browse the repository at this point in the history
The C code is generated naively and we do not try to remove dead parts.
Thus silent C compiler warnings about unreachable things.

Close nitlang#2780

Signed-off-by: Jean Privat <[email protected]>
  • Loading branch information
privat committed Aug 14, 2019
1 parent 17ea05c commit 6fa05a2
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/compiler/abstract_compiler.nit
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ endif
ifeq ($(origin CXX), default)
CXX = ccache c++
endif
CFLAGS ?= -g {{{if not debug then "-O2" else ""}}} -Wno-unused-value -Wno-switch -Wno-attributes -Wno-trigraphs
CFLAGS ?= -g {{{if not debug then "-O2" else ""}}} -Wno-unused-value -Wno-switch -Wno-attributes -Wno-trigraphs -Wno-switch-unreachable
CINCL =
LDFLAGS ?=
LDLIBS ?= -lm {{{linker_options.join(" ")}}}
Expand Down
4 changes: 4 additions & 0 deletions tests/sav/test_generic_nullable.res
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
0
0
1
2
35 changes: 35 additions & 0 deletions tests/test_generic_nullable.nit
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# This file is part of NIT ( http://www.nitlanguage.org ).
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import core::kernel

class C[E]
var x: E
fun read_or_die
do
if x != null then
x.as(not null).output
else
0.output
end
end
end
var c1 = new C[nullable Object](null)
var c2 = new C[nullable Int](null)
c1.read_or_die
c2.read_or_die
c1.x = 1
c2.x = 2
c1.read_or_die
c2.read_or_die

0 comments on commit 6fa05a2

Please sign in to comment.