Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: make gcloud project name configurable using secret #292

Merged
merged 1 commit into from
Nov 8, 2024
Merged

CI/CD: make gcloud project name configurable using secret #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ This means you need to upload every secret twice.
- `APPLE_DEVELOPMENT_CERTIFICATE`: Base64 encoded PKCS12 certificate of the Apple development certificate, check the [Fastlane docs](../../fastlane/README.md#generating-new-certificates) for generating instructions. This certificate expires every year and is linked to the 'IRMA Beheer' email address.
- `APPLE_DEVELOPMENT_CERTIFICATE_PASSWORD`: password of the Apple development certificate (see above).
- `APPLE_DEVELOPMENT_PROVISIONING_PROFILE`: Base64 encoded Apple provisioning profile that is linked to the development certificate (see above). This should be renewed when the development certificate is being renewed.
- `GCLOUD_PROJECT_NAME`: Google Firebase project name (for Device Test Lab access).
- `GCLOUD_SERVICE_KEY`: Google Firebase service account JSON key (for Device Test Lab access).

## Delivery
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/status-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ jobs:
run: gcloud auth activate-service-account --key-file <(echo $GCLOUD_SERVICE_KEY)
shell: bash
- name: Set Firebase project
run: gcloud config set project yivimobile
run: gcloud config set project ${{ secrets.GCLOUD_PROJECT_NAME }}
- name: Run integration tests
run: gcloud firebase test ios run --test ios_tests.zip --timeout 20m --device=model=iphone8,orientation=portrait --device=model=iphone8,orientation=landscape
integration-test-android:
Expand All @@ -246,6 +246,6 @@ jobs:
run: gcloud auth activate-service-account --key-file <(echo $GCLOUD_SERVICE_KEY)
shell: bash
- name: Set Firebase project
run: gcloud config set project yivimobile
run: gcloud config set project ${{ secrets.GCLOUD_PROJECT_NAME }}
- name: Run integration tests
run: gcloud firebase test android run --use-orchestrator --app app-alpha-debug.apk --test app-alpha-debug-androidTest.apk --timeout 20m --device=model=Pixel2,version=28,orientation=portrait --device=model=Pixel2,version=28,orientation=landscape