new keyshare protocol (keyshare server parts) #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… still work in progress.
…_0^secret) prior to issuance. This is needed for the client to calculate the hash h_w.
Implement /getPs endpoint for new keyshare protocol
# Conflicts: # server/keyshare/keyshareserver/server.go # server/keyshare/keyshareserver/server_test.go
…ably secure keyshare protocol. The upgrade includes breaking changes in both the keyshare server and the app client. Since this pull request will only update the keyshare server, the client code is not upgraded properly here but merely so that it compiles again.
…l builder. Accidently committed the placeholder earlier.
This version of gabi produces a proofU that contains both keyshares. This commit changes the following:
- irmaclient.Client.startKeyshareSession() is now called newKeyshareSession, because it does not actually immediately start the session. Instead, it returns after checking the user's PIN. This is necessary because what happens next now differs per session type, see next point.
- In case of disclosure/ABS, the session proceeds as before. In case of issuance, /api/v2/prove/getPs at the keyshare server is first invoked to retrieve the P values (R_0^{keyshare server secret}), after which the session is started.
- In case of the old keyshare protocol, the keyshare's P is divided out from the U of the proofU because that is what the issuer expects in the old keyshare protocol.
Support gabi with updated keyshare protocol
Get commitments
Master merge only
Keyshare server getResponse v2 endpoints
ivard
reviewed
Aug 1, 2023
…gacy-issuance Fix keyshare server sessions involving a legacy issuer
…move-todos Chore: remove leftover TODOs (new keyshare protocol)
Chore: make PMap JSON tags consistent with variable names
ivard
changed the title
ivard
previously approved these changes
Sep 5, 2023
ivard
previously approved these changes
Sep 5, 2023
ivard
approved these changes
Sep 27, 2023
bobhageman
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client implementation follows in #327.