-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add toolbar events #89
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e982a6a
feat: add window and redirect middleware
lihbr 689f5d8
chore: in case of middleware redirect error explain the issue to deve…
lihbr 5fdd3b6
fix: await middleware run
lihbr 360cd2e
test: update middleware test
lihbr d6d1035
fix: return next middleware callback in case of error
lihbr 2637d51
fix: allow multiple origin for prismic toolbar
lihbr b7f0c0d
refactor: remove redirect middleware and use better naming
lihbr 6771d7a
refactor: use native events
lihbr 7c72e59
refactor: use dispatchToolbarEvent for init event too
lihbr b924827
bumb version numeber to 4.0.6
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"compilerOptions": { | ||
"resolveJsonModule": true, | ||
"baseUrl": ".", | ||
"paths": { | ||
"@common": ["./src/common"], | ||
"@common/*": ["./src/common/*"], | ||
} | ||
}, | ||
"exclude": ["node_modules", "build"] | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
export const toolbarEvents = { | ||
prismic: 'prismic', | ||
previewUpdate: 'prismicPreviewUpdate', | ||
previewEnd: 'prismicPreviewEnd' | ||
}; | ||
|
||
/** | ||
* Dispatches an event with given data | ||
* | ||
* @param {string} event - Event name | ||
* @param {?any} data - Data to attach to the event | ||
* | ||
* @return {boolean} - `true` if event `event.preventDefault()` | ||
* was not called (event was not cancelled) | ||
*/ | ||
export const dispatchToolbarEvent = (event, data = null) => | ||
window.dispatchEvent(new CustomEvent(event, { | ||
detail: data, | ||
cancelable: true | ||
})); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if this is still necessary (if the toolbar is not loaded when no cookie is found, we can get rid of this @arnaudlewis)