Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uids matching for better prediction #79

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

srenault
Copy link
Contributor

@srenault srenault commented Feb 5, 2021

fixes prismicio/issue-tracker-wroom#380

@francois-riviere
Copy link

Copy link

@bapmrl bapmrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't seem to fix the issue-tracker-wroom/issues/108 issue. I've included a screenshot there.

Please note that I've pushed f73156f because the code was not compiling (Error: Cannot find module 'is-obj') and not linting.

@MarcMcIntosh
Copy link
Contributor

MarcMcIntosh commented Jul 6, 2021

Okay this PR is linked to a few issues.
https://github.com/prismicio/issue-tracker-wroom/issues/108
and
https://github.com/prismicio/issue-tracker-wroom/issues/380

The issue is fixed :) I also added a test

@francois-riviere
Copy link

but Baptiste was saying that the PR doesn't fix #108

@MarcMcIntosh
Copy link
Contributor

MarcMcIntosh commented Jul 6, 2021

@francois-riviere did he say that today?

I made a small change then added a test, you can see the results in the picture in this comment https://github.com/prismicio/issue-tracker-wroom/issues/108#issuecomment-874822253

@francois-riviere
Copy link

he left a comment just above on Mar 12

@SamWaiHaSB
Copy link

Hello,

Sorry to comment on an old PR. Do we know if this has been resolved in newer versions of Prismic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants