-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uids matching for better prediction #79
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't seem to fix the issue-tracker-wroom/issues/108 issue. I've included a screenshot there.
Please note that I've pushed f73156f because the code was not compiling (Error: Cannot find module 'is-obj'
) and not linting.
Okay this PR is linked to a few issues. The issue is fixed :) I also added a test |
but Baptiste was saying that the PR doesn't fix #108 |
@francois-riviere did he say that today? I made a small change then added a test, you can see the results in the picture in this comment https://github.com/prismicio/issue-tracker-wroom/issues/108#issuecomment-874822253 |
he left a comment just above on Mar 12 |
Hello, Sorry to comment on an old PR. Do we know if this has been resolved in newer versions of Prismic? |
fixes prismicio/issue-tracker-wroom#380