Bulk Improvements #312
Open
Bulk Improvements #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra terminator when encoding zero-length values for large va…
Open
ibotty
reviewed
Jan 24, 2024
| if options.bits() > 0 || order_hints.len() > 0 { | ||
| let mut add_separator = false; | ||
| query.push_str(" WITH ("); | ||
| if options.contains(SqlBulkCopyOptions::KeepNulls) { |
There was a problem hiding this comment.
Can't you use bitflags's Flag::iter and join to simplify the whole separator business?
|
It would be great to have this pull request merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.