feat(schema-engine): prepare skeleton for implicit many-to-many table logical replication on Postgres #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logical replication on Postgres
jkomyno
commented
Nov 22, 2024
Comment on lines
+411
to
+414
| let refinement_str = match table.is_implicit_m2m() { | ||
| true => "-- Implicitly many-to-many\n", | ||
| false => "", | ||
| }; |
There was a problem hiding this comment.
This is debug-only stuff
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5051 will not alter performanceComparing Summary
|
aqrln
reviewed
Nov 25, 2024
| @@ -657,6 +663,7 @@ pub(crate) enum Circumstances { | |||
| IsCockroachDb, | |||
| CockroachWithPostgresNativeTypes, // FIXME: we should really break and remove this | |||
There was a problem hiding this comment.
hmm, unrelated to this pr but: we did break this case in Prisma 5 already, we can probably just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT, expect failures and incomplete code
This PR: