Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #3882

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Release tracking #3882

merged 1 commit into from
Oct 31, 2023

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Oct 30, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Major Changes

  • #3384 3633535c Thanks @joshblack! - Update styled-components and related dependencies to v5.x

  • #3384 3633535c Thanks @joshblack! - Remove components from deprecated

    • BorderBox, ChoiceFieldset, Flex, Grid, Position, Dropdown, FormGroup, SelectMenu, InputField, Label
  • #3384 3633535c Thanks @joshblack! - Remove components from draft bundle

    • Move UnderlineNav2 (draft) to the main bundle
    - import {UnderlineNav} from '@primer/react/drafts'
    + import {UnderlineNav} from '@primer/react'

    ....

    • Remove TreeView from drafts
    - import {TreeView} from '@primer/react/drafts'
    + import {TreeView} from '@primer/react'
    • Remove SegmentedControl from drafts
    - import {SegmentedControl} from '@primer/react/drafts'
    + import {SegmentedControl} from '@primer/react'
    • Remove NavList from drafts
    - import {NavList} from '@primer/react/drafts'
    + import {NavList} from '@primer/react'
    • Remove SplitPageLayout from drafts
    - import {SplitPageLayout} from '@primer/react/drafts'
    + import {SplitPageLayout} from '@primer/react'
  • #3384 3633535c Thanks @joshblack! - - Changes leadingIcon and trailingIcon to leadingVisual and trailingVisual

    • Removes Button.Counter as a child component, replacing it with a count prop. This change allows us to use the trailingVisual slot for counters.
    • Removes the outline button variant as we wish to only support invisible buttons.
  • #3384 3633535c Thanks @joshblack! - Remove deprecated extralarge variant from Token and TextInputWithToken component

  • #3384 3633535c Thanks @joshblack! - Remove StyledOcticon component. The component was renamed to Octicon. Update your imports by swapping StyledOcticon with Octicon

  • #3384 3633535c Thanks @joshblack! - Deprecates FilterList and FilteredSearch components

  • #3384 3633535c Thanks @joshblack! - Makes @types/styled-components an optional peer dependency, not a dependency

  • #3384 3633535c Thanks @joshblack! - ConfirmationDialog: Use createRoot instead of ReactDOM.render for React 18 compatibility.

  • #3384 3633535c Thanks @joshblack! - Update minimum version for react and react-dom to v18

  • #3384 3633535c Thanks @joshblack! - Remove DropdownButton and DropdownMenu from deprecated and update the usages across

  • #3384 3633535c Thanks @joshblack! - The Autocomplete component no longer uses the deprecated ActionList component. There have been minor API updates, but it's largely the same.

  • #3384 3633535c Thanks @joshblack! - Removes 'warning' option from form components' validationStatus props

  • #3384 3633535c Thanks @joshblack! - Remove support for activeClassName for Breadcrumb, SubNav, TabNav, UnderlineNav

  • #3384 3633535c Thanks @joshblack! - Ensure ActionList item has border-radius on hover with full variant

Patch Changes

@primer primer bot requested review from a team and broccolinisoup October 30, 2023 20:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass on this pull request
  • Docs and Storybook open in a browser
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🌏 Integration tests

  • Successful integration test with github/github as a primary consumer of Primer React (automated pull request)
    • Verify all CI checks have passed on automated pull request
    • Manually test critical paths in the review-lab
    • Manually test release-specific bugfixes and/or features work as described in the review-lab

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Upgrade @primer/react version at github/github

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes on the weekly release tracking issue. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to the next release conductor as well as maintainers.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 103.55 KB (0%)
dist/browser.umd.js 104.13 KB (0%)

@primer primer bot temporarily deployed to github-pages October 30, 2023 20:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3882 October 30, 2023 20:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3882 October 30, 2023 20:39 Inactive
@primer primer bot temporarily deployed to github-pages October 30, 2023 20:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3882 October 30, 2023 20:48 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotcom integration are passing, let's goooooo!

@siddharthkp siddharthkp added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 82a4e30 Oct 31, 2023
30 checks passed
@siddharthkp siddharthkp deleted the changeset-release/main branch October 31, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant