Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageHeader: Address general sign-off review feedback in storybook (missing href values, non-working menus) #3817

Merged
merged 10 commits into from
Oct 17, 2023
Merged

PageHeader: Address general sign-off review feedback in storybook (missing href values, non-working menus) #3817

merged 10 commits into from
Oct 17, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Oct 13, 2023 •
edited
Loading

As a part of addressing accessibility sign-off review comments https://github.com/github/primer/issues/1115#issuecomment-1499501472

Changelog

New

Changed

  • Update Non-descriptive button texts : "More" vs "More file actions"
  • Update the Pull request page example highest level heading is to h1
  • Add proper href values to the examples
  • Add action menus to the icon button anchors. (The buttons previously weren't doing anything which is wrong now they should display proper menus )

Removed

  • Pull request Example PR a scrollable text area. It is not related to the component and we don't even have it in production. I removed to simplify the example.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1ec1f8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup added skip changeset This change does not need a changelog component: page header labels Oct 13, 2023
@broccolinisoup broccolinisoup changed the title Pageheader sign off fixes PageHeader: Address general sign-off review feedback in storybook (missing href values, non-working menus) Oct 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.74 KB (0%)
dist/browser.umd.js 105.32 KB (0%)

@broccolinisoup broccolinisoup temporarily deployed to github-pages October 13, 2023 05:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3817 October 13, 2023 05:59 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review October 13, 2023 06:14
@broccolinisoup broccolinisoup requested review from a team, josepmartins and pksjce October 13, 2023 06:14
pksjce
pksjce approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@pksjce pksjce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look fine to me based on your comments here.

src/PageHeader/PageHeader.features.stories.tsx
</Breadcrumbs>
<VisuallyHidden as="h2">Visually Hidden Title</VisuallyHidden>
<VisuallyHidden as="h2">PageHeader.tsx</VisuallyHidden>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be h1 as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my bad. I just read your replies to @jscholes. I see this is intentional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch! @pksjce

Just to clarify, the h2 intentional ones I mentioned in my response are the ones under the settings page (reference)

Looking at the current files page implementation, seems like it has changed since I built this component and stories and it should be h1. However, we will address the cases where breadcrumb components are used as a title in the following PageHeader PR and the structure will change a bit, so I think we can leave this as is to reduce the number of merge conflicts if that is okay?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! That seems fine with me. This one is good to merge 👍

@broccolinisoup broccolinisoup added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 32b8705 Oct 17, 2023
28 checks passed
@broccolinisoup broccolinisoup deleted the pageheader-sign-off-fixes branch October 17, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksjce pksjce pksjce approved these changes

@josepmartins josepmartins Awaiting requested review from josepmartins

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@broccolinisoup @pksjce